Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Messaging refactor develop #310

Merged
merged 11 commits into from
Aug 17, 2022
Merged

Messaging refactor develop #310

merged 11 commits into from
Aug 17, 2022

Conversation

hongdami
Copy link

@hongdami hongdami commented Aug 15, 2022 •
edited
Loading

Issue Number:

Objective of pull request:

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

@hongdami
Copy the python file from depricated_message_infrastructure/*.py
c8dd3ed
@hongdami
change multiprocessing.py to adapt interface
97e9a8f
@hongdami
fix cpplint error
8ef9c5d
@hongdami
Update cpplib side MultiProcessing:
8eadce5 
1. message_infrastructure_logging.h: logging for development
2. abstract_actor.h&posix_actor.cc: achieve stop function for signal
3. shm.h: Add SharedMemoryManager to cpplib
4. others: Update CMake, test and fix some type error'

fix pylint error
@hongdami
Update API Interface
4cd04ed 
1. multiprocessing.py: Fix bug for sharedmemmanager name
2. remove lava package dependency for message_infrastructure
3. multiprocessing.cc: Add shmm and actors function
4. abstract_actor.h: Modify the posix actor and interface design
5. add and update test for multiprocessing

Signed-off-by: Miao, Hongda <[email protected]>
killight98
killight98 requested changes Aug 17, 2022
View reviewed changes
src/lava/magma/compiler/builders/channel_builder.py Outdated Show resolved Hide resolved
src/lava/magma/compiler/channels/pypychannel.py Outdated Show resolved Hide resolved
src/lava/magma/runtime/runtime.py Outdated Show resolved Hide resolved
hongdami
hongdami commented Aug 17, 2022
View reviewed changes
Copy link
Author

@hongdami hongdami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. update import path and init.py
  2. fix typoerror
  3. update bounded function to cpp
  4. update pywrapper
  5. add test for multiprocessing.py

@hongdami
Update import from message_infrastructure:
024fde2 
1. Move message_interface_enum.py to message_infrastructure
2. Update import syntax
3. Others: change multiprocessing init

Signed-off-by: Miao, Hongda <[email protected]>
@hongdami
Update test_runtime.py import
f502f81 
Signed-off-by: Miao, Hongda <[email protected]>
@hongdami hongdami merged commit fc15bbd into lava-nc:messaging_refactor_develop Aug 17, 2022
seowwj added a commit to seowwj/lava that referenced this pull request Aug 17, 2022
@seowwj
Merge pull request #3 from lava-nc/messaging_refactor_develop
8f2d512 
Merging PR lava-nc#310 from upstream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hexu33 hexu33 hexu33 approved these changes

@killight98 killight98 killight98 approved these changes

@shaline-koh shaline-koh Awaiting requested review from shaline-koh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hongdami @killight98 @hexu33